[Bug 212335] mail/spamd: /etc/services entries are deleted on reinstall

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

Mathieu Arnold <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|***@FreeBSD.org |***@FreeBSD.org

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #2 from Adam Weinberger <***@FreeBSD.org> ---
Can someone from pkg@ weigh in here?

Olli: is it worth disabling the pkg-deinstall for now?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #3 from Adam Weinberger <***@FreeBSD.org> ---
Olli, pkg@ has a huge bug backlog (currently 50 here and over 200 on github).
I'd recommend that spamd disable its pkg-deinstall until the bug in pkg gets
fixed.

It eliminates the behaviour of spamd breaking on upgrade/reinstall, and the
only negative side effect is that the entries for spamd remain in /etc/services
if spamd is uninstalled.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #4 from Baptiste Daroussin <***@FreeBSD.org> ---
The order is actually expected. I should probably document somewhere the why
and the how an upgrade is process. But this is totally not a first deinstall
then install as it does not work at all on complex cases.

the backlog, on pkg is mostly feature request or thing we keep open because we
do not necessary agree in the beginning with the request that have been made,
but we might change our mind in the feature :)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #5 from Adam Weinberger <***@FreeBSD.org> ---
So then what's the right way for spamd to handle adding and removing lines from
/etc/services? If it adds the lines in POST-INSTALL would that always run after
DEINSTALL?

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #6 from Baptiste Daroussin <***@FreeBSD.org> ---
The right way is to add things in post-install: aka only if the installation
has succeed which is anyway better

Actually the best would be to add a keyword for that :) so all ports adding
services would benefit from it :)

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #7 from Baptiste Daroussin <***@FreeBSD.org> ---
I would propose this:
https://reviews.freebsd.org/D8504

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #9 from Adam Weinberger <***@FreeBSD.org> ---
Olli, it's been almost a year since you commented on this bug. Unless you
register an objection before then, I'm going to disable the pkg-deinstall on
Saturday.

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #10 from commit-***@freebsd.org ---
A commit references this bug:

Author: adamw
Date: Fri Sep 1 22:03:05 UTC 2017
New revision: 449108
URL: https://svnweb.freebsd.org/changeset/ports/449108

Log:
Disable the pkg-deinstall script.

spamd's pkg-install adds spamd stuff to /etc/services, and pkg-deinstall
removed it. The problem is that pkg doesn't run DEINSTALL before INSTALL
when upgrading/reinstalling. As a result, when spamd is restarted,
/etc/services winds up lacking the spamd entries, causing spamd to fail
to start.

The ideal solution is pkg running those targets in the predicted order,
or pkg gaining a @services keyword. In the meantime, this commit just
disables the pkg-deinstall. If you are uninstalling spamd you can remove
those /etc/services entries by hand.

PR: 212335
Approved by: maintainer timeout (~ 1 yr)
MFH: 2017Q3

Changes:
head/mail/spamd/Makefile
head/mail/spamd/pkg-deinstall

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

--- Comment #11 from commit-***@freebsd.org ---
A commit references this bug:

Author: adamw
Date: Sat Sep 2 15:03:53 UTC 2017
New revision: 449149
URL: https://svnweb.freebsd.org/changeset/ports/449149

Log:
MFH: r449108

Disable the pkg-deinstall script.

spamd's pkg-install adds spamd stuff to /etc/services, and pkg-deinstall
removed it. The problem is that pkg doesn't run DEINSTALL before INSTALL
when upgrading/reinstalling. As a result, when spamd is restarted,
/etc/services winds up lacking the spamd entries, causing spamd to fail
to start.

The ideal solution is pkg running those targets in the predicted order,
or pkg gaining a @services keyword. In the meantime, this commit just
disables the pkg-deinstall. If you are uninstalling spamd you can remove
those /etc/services entries by hand.

PR: 212335
Approved by: maintainer timeout (~ 1 yr)

Approved by: ports-secteam (delphij)

Changes:
_U branches/2017Q3/
branches/2017Q3/mail/spamd/Makefile
branches/2017Q3/mail/spamd/pkg-deinstall

[b***@freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212335

Adam Weinberger <***@FreeBSD.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Open |Closed

--- Comment #12 from Adam Weinberger <***@FreeBSD.org> ---
Closing this. I don't think a pkg behaviour change in this area is coming, and
it works well-enough with the current patch.